Add App Clip to Demo project #659

mokagio · 2025-02-07T01:22:03Z

Internal ref pdnsEh-21E-p2

Description

Adds an App Clip to the Demo project
Wires up code signing for the Debug configuration — More work required for the Release build, given it can only be tested on the App Store account and we don't have it set up yet
Updates the Prototype Build automation to strip the App Clip. The Prototype Build is distributed via the Enterprise account but Enterprise apps are not allowed App Clips.

Testing Steps

Checkout this branch and run the debug build on device.

Here's a screenshot from mine:

Where to go from here

For @andrewdmontgomery @pinarol & team to

Implement the actual App Clip. What's here is just the Xcode template
Let me / @Automattic/apps-infrastructure know whether to set up TestFlight distribution to test the App Clip without having to deploy the app on device. That will require a bunch of Fastlane updates, so I didn't go down that path in the context of this PR.

This is only to show a screenshot of the App Clip running on my device that is obviously the one in this codebase.

I run into an issue testing the prototype build automation and before trying to debug it, I thought I'd make sure we're on the latest tooling.

For consistency with where the App Clip entitlements file is, that is.

mokagio · 2025-02-07T04:07:27Z

fastlane/Fastfile

+# rubocop:disable Metrics/AbcSize
+# rubocop:disable Metrics/CyclomaticComplexity
+def remove_app_clip_dependency!
+  project_path = XCODEPROJ_PATH
+  project = Xcodeproj::Project.open(project_path)
+
+  native_targets = project.targets.select { |t| t.is_a?(Xcodeproj::Project::Object::PBXNativeTarget) }
+  app_targets = native_targets.select { |t| t.product_type == 'com.apple.product-type.application' }
+  app_clip_targets = native_targets.select { |t| t.product_type == 'com.apple.product-type.application.on-demand-install-capable' }
+
+  if app_clip_targets.empty?
+    UI.user_error!("No on-demand-install-capable targets found in #{project_path}. Has something changed in the project structure? Aborting App Clips removal.")
+  end
+
+  app_targets.each do |app|
+    # Delete any dependency of the app target that is an app_clip target
+    app.dependencies.delete_if { |dep| app_clip_targets.include?(dep.target) }
+    # Delete the "Embed App Clips" build phase
+    app.build_phases.delete_if { |b| b.display_name == 'Embed App Clips' }
+  end
+
+  UI.message('Saving the project file....')
+  project.save
+
+  UI.success('Dependency successfuly removed.')
+end
+# rubocop:enable Metrics/AbcSize
+# rubocop:enable Metrics/CyclomaticComplexity


This is duplicated from Pocket Casts. We might want to centralize at the release toolkit level, see wordpress-mobile/release-toolkit#629

Oh right, the original development profile is for an Enterprise app, which doesn't support App Clips. Thanks for this.

~~@mokagio given that's the second repo/app for which we need to do that trick (removing AppClip for Enterprise / Prototype builds to compile), worth P2-ing about it for future reference?~~

NVM, I missed your comment above suggesting to centralize this at the release-toolkit level, which would indeed be an even better idea 👍

wpmobilebot · 2025-02-07T04:08:44Z

📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.

	App Name	Gravatar Prototype Build
	Build Number	2119
	Version	1.0
	Bundle ID	com.automattic.gravatar-sdk-demo-uikit.prototype-build
	Commit	`b17a5fd`
	App Center Build	Gravatar SDK Demo - UIKit #603

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

pinarol · 2025-02-07T08:19:40Z

Thank you very much! This is very useful for us. I won't merge it for now as this effort might move to a separate repo.

pinarol · 2025-02-07T13:21:38Z

@mokagio The app clip target works fine but this time, I can't get the old demo app target to build in this branch. I get the error: The CFBundleVersion of an App Clip ('1') must match that of its containing parent app ('0').

pinarol · 2025-02-07T13:26:31Z

Also, we need to test OAuth in the app clip target so we'll need this config. Does this require updating the provisioning profile also? @mokagio

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>com.apple.developer.associated-domains</key>
	<array>
		<string>appclips:gravatar.com</string>
		<string>applinks:gravatar.com</string>
		<string>webcredentials:gravatar.com</string>
	</array>
	<key>com.apple.developer.parent-application-identifiers</key>
	<array>
		<string>$(AppIdentifierPrefix)com.automattic.gravatar-sdk-demo-uikit</string>
	</array>
</dict>
</plist>

andrewdmontgomery · 2025-02-07T16:33:31Z

@mokagio The app clip target works fine but this time, I can't get the old demo app target to build in this branch. I get the error: The CFBundleVersion of an App Clip ('1') must match that of its containing parent app ('0').

I fixed this. [5e5a614]

andrewdmontgomery · 2025-02-07T16:39:38Z

Does this require updating the provisioning profile also?

Ah, yes, I believe it does. Apologies, I didn't consider that when I opened the request. Thanks for catching it.

andrewdmontgomery · 2025-02-07T20:22:16Z

This happens on a device, when I attempt to install/run the Demo App after having installed/ran the App Clip:

Edit: I had more than one previous version of the "Gravatar Demo" apps installed, from back when we had two demo targets (SwiftUI and UIKit). Removed. Problem solved.

mokagio · 2025-02-10T00:30:52Z

Also, we need to test OAuth in the app clip target so we'll need this config. Does this require updating the provisioning profile also? @mokagio

@pinarol @andrewdmontgomery

51b5a1a addresses this.

The app clip already had the associated domains capability because of the appclips:gravatar.com domain, so no update at the developer portal level was needed.

This will make it clearer that they are shared once we'll read them from the app clip extension, too.

dangermattic · 2025-02-10T00:38:48Z

	1 Error
🚫	This PR is tagged with `do not merge` label(s).

Generated by 🚫 Danger

mokagio added 7 commits February 7, 2025 11:55

Add App Clip to Demo project

80cab2d

Rename App Clip folder to Demo-App-Clip

e255c78

Use correct bundle identifier for App Clip target

ce0a479

Add appclips:gravatar.com associated domain to both app and clip

30fbe3e

Remove snake casing from App Clip SwiftUI App

23e672a

Rename App Clip entitlement to match folder name

66e048f

Configure provisioning profile for Debug – Includes entitlements fix

f7fba40

mokagio added the demoapp Demo App Changes label Feb 7, 2025

mokagio added 4 commits February 7, 2025 12:56

Update dummy text in App Clip ContentView.swift

dbdce7a

This is only to show a screenshot of the App Clip running on my device that is obviously the one in this codebase.

Update Fastlane to latest version, 2.226.0

f8b7a66

I run into an issue testing the prototype build automation and before trying to debug it, I thought I'd make sure we're on the latest tooling.

Update automation to strip App Clip when building prototype build

89aa1c3

Move Demo app entitlement to Demo sources folder for consistency

c11c843

For consistency with where the App Clip entitlements file is, that is.

mokagio force-pushed the experiment/app-clip branch from 62ad28b to c11c843 Compare February 7, 2025 03:59

mokagio mentioned this pull request Feb 7, 2025

Port automation to strip App Clip from Enterprise target to release-toolkit wordpress-mobile/release-toolkit#629

Open

mokagio commented Feb 7, 2025

View reviewed changes

mokagio marked this pull request as ready for review February 7, 2025 04:12

mokagio requested review from andrewdmontgomery, a team and pinarol February 7, 2025 04:12

Change App Clip CURRENT_PROJECT_VERSION (CFBundleVersion) to match App

5e5a614

Add associated domains for OAUth to App Clip

51b5a1a

mokagio mentioned this pull request Feb 10, 2025

Leverage xcconfig for App Clip project, too #663

Merged

mokagio added 5 commits February 10, 2025 11:37

Move project-level xcconfig for demo app to dedicated folder

382b8f2

This will make it clearer that they are shared once we'll read them from the app clip extension, too.

Inherit App Clip version from Base.xcconfig

171ccf6

Inherit App Clip IPHONEOS_DEPLOYMENT_TARGET from project-level setting

c3c161f

DRY Demo project IPHONEOS_DEPLOYMENT_TARGET to Base.xcconfig

acf4606

Inherit App target CURRENT_PROJECT_VERSION from xcconfig

b46367e

mokagio added the do not merge label Feb 10, 2025

Leverage xcconfig for App Clip project, too (#663)

b17a5fd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add App Clip to Demo project #659

Add App Clip to Demo project #659

mokagio commented Feb 7, 2025 •

edited

Loading

mokagio Feb 7, 2025

andrewdmontgomery Feb 7, 2025

AliSoftware Feb 7, 2025 •

edited

Loading

wpmobilebot commented Feb 7, 2025 •

edited

Loading

pinarol commented Feb 7, 2025

pinarol commented Feb 7, 2025

pinarol commented Feb 7, 2025

andrewdmontgomery commented Feb 7, 2025

andrewdmontgomery commented Feb 7, 2025

andrewdmontgomery commented Feb 7, 2025 •

edited

Loading

mokagio commented Feb 10, 2025

dangermattic commented Feb 10, 2025

Add App Clip to Demo project #659

Are you sure you want to change the base?

Add App Clip to Demo project #659

Conversation

mokagio commented Feb 7, 2025 • edited Loading

Description

Testing Steps

Where to go from here

mokagio Feb 7, 2025

Choose a reason for hiding this comment

andrewdmontgomery Feb 7, 2025

Choose a reason for hiding this comment

AliSoftware Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

wpmobilebot commented Feb 7, 2025 • edited Loading

pinarol commented Feb 7, 2025

pinarol commented Feb 7, 2025

pinarol commented Feb 7, 2025

andrewdmontgomery commented Feb 7, 2025

andrewdmontgomery commented Feb 7, 2025

andrewdmontgomery commented Feb 7, 2025 • edited Loading

mokagio commented Feb 10, 2025

dangermattic commented Feb 10, 2025

mokagio commented Feb 7, 2025 •

edited

Loading

AliSoftware Feb 7, 2025 •

edited

Loading

wpmobilebot commented Feb 7, 2025 •

edited

Loading

andrewdmontgomery commented Feb 7, 2025 •

edited

Loading